Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] gofmt with go1.19 #1036

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Dec 8, 2022

No description provided.

@knative-prow
Copy link

knative-prow bot commented Dec 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1036 (722b368) into release-1.6 (1ef367e) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.6    #1036   +/-   ##
============================================
  Coverage        80.91%   80.91%           
============================================
  Files               18       18           
  Lines             1603     1603           
============================================
  Hits              1297     1297           
  Misses             223      223           
  Partials            83       83           
Impacted Files Coverage Δ
pkg/reconciler/ingress/ingress.go 73.47% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dprotaso
Copy link
Contributor Author

dprotaso commented Dec 8, 2022

/assign @psschwei

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@dprotaso
Copy link
Contributor Author

dprotaso commented Dec 8, 2022

Known flake

#938

@dprotaso
Copy link
Contributor Author

dprotaso commented Dec 8, 2022

/override integration-tests_net-istio_release-1.6

@knative-prow
Copy link

knative-prow bot commented Dec 8, 2022

@dprotaso: Overrode contexts on behalf of dprotaso: integration-tests_net-istio_release-1.6

In response to this:

/override integration-tests_net-istio_release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 2de60cc into knative-extensions:release-1.6 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants