fix(#27): Enable SSL transport options on sources #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christophd: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: christophd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
christophd
force-pushed
the
issue/27/ssl-transport-options
branch
from
13f6e68
to
f9d1b86
Compare
pierDipi
reviewed
Oct 17, 2024
| The integration source needs to enable the SSL client via environment variables and set the path to the injected CA certs and PEM files: | ||
|
|
||
| * CAMEL_KNATIVE_CLIENT_SSL_ENABLED=true | ||
| * CAMEL_KNATIVE_CLIENT_SSL_KEY_PATH=/knative-custom-certs/knative-eventing-bundle.pem |
There was a problem hiding this comment.
/knative-custom-certs/... can potentially have multiple files https://knative.dev/docs/eventing/features/transport-encryption/#configure-custom-event-sources-to-trust-the-eventing-ca
There was a problem hiding this comment.
hm, this requires more sophisticated configuration then. Let's open a follow-up issue for supporting multiple files, ok?
| options.setKeyCertOptions(new PemKeyCertOptions().setKeyPath(keyPath).setCertPath(certPath)); | ||
| } | ||
|
|
||
| options.setTrustOptions(TrustAllOptions.INSTANCE); |
There was a problem hiding this comment.
is this config trusting any CA without using /knative-custom-certs/... config?
There was a problem hiding this comment.
So far I have only seen keystores being injected into /knative-custom-certs/. should knative-eventing-bundle.jks also be used as a truststore then?
I will add a configuration option for truststore path and password and just use TrustAll option as a default when nothing is set, WDYT?
aws-s3-source/src/main/java/dev/knative/eventing/KnativeClientOptions.java
Outdated
Show resolved
Hide resolved
pierDipi
reviewed
Oct 17, 2024
aws-s3-source/src/main/java/dev/knative/eventing/KnativeClientOptions.java
Outdated
Show resolved
Hide resolved
christophd
force-pushed
the
issue/27/ssl-transport-options
branch
from
f9d1b86
to
7eb696d
Compare
|
Ok, I have partially tested this. I;ve copied the but still, I seem to get the following in my reconciler-tests: |
christophd
force-pushed
the
issue/27/ssl-transport-options
branch
from
7eb696d
to
04b2382
Compare
christophd
force-pushed
the
issue/27/ssl-transport-options
branch
2 times, most recently
from
16f1e56
to
9aa1709
Compare
- Adds Http client SSL transport options - Uses options as a Camel bean and configures via environment variables when SSL is enabled - Enables SSL support on all sources
christophd
force-pushed
the
issue/27/ssl-transport-options
branch
from
9aa1709
to
302c991
Compare
|
@christophd thx for update. back to work on Thursday - will take a look then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind enhancement
Fixes #27
Release Note
Docs