Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): increase max_post_size from 64kb to 2mib #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+75 −65
Open

fix(server): increase max_post_size from 64kb to 2mib #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 75 additions & 65 deletions src/server--async.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
$config = [];
$twigRenderer = null;
$counter = 0;
$maxConcurrency = 100;

try {
$configString = file_get_contents($configFilePath);
Expand All @@ -47,6 +48,10 @@

if ($config) {
$twigRenderer = new TwigRenderer($config);

if(array_key_exists('maxConcurrency', $config)) {
$maxConcurrency = $config['maxConcurrency'];
}
// file_put_contents(__DIR__ . '/info.json', json_encode($twigRenderer->getInfo()));
}

Expand All @@ -59,80 +64,85 @@ function formatResponseBody($msgs = [], $ok = false, $html = ''): string
], JSON_THROW_ON_ERROR);
}

$server = new HttpServer(static function (ServerRequestInterface $request) use ($twigRenderer, &$counter): Response|Promise {
$headers = [
'Content-Type' => 'application/json',
'Access-Control-Allow-Origin' => '*',
];
$msgs = [];
++$counter;
$method = $request->getMethod();
$query = $request->getQueryParams();
$body = $request->getBody()->getContents();

try {
$body = json_decode($body ?: '{}', true, 512, JSON_THROW_ON_ERROR);
} catch (\Exception $exception) {
// @todo why doesn't this catch errors from malformed JSON?
$msgs[] = 'Not able to parse JSON. '.$exception->getMessage();

return new Response(400, $headers, formatResponseBody($msgs));
}

if (!isset($query['type'])) {
return new Response(
202,
$headers,
json_encode([
'ok' => true,
'message' => "No action correctly requested. Url must have a query param of 'templatePath' for which twig template to render, but yes - the server is running.",
])
);
}

// one of: meta, renderFile, renderString
$type = $query['type'];

switch ($type) {
case 'meta':
$server = new HttpServer(
new React\Http\Middleware\StreamingRequestMiddleware(),
new React\Http\Middleware\LimitConcurrentRequestsMiddleware($maxConcurrency),
new React\Http\Middleware\RequestBodyBufferMiddleware(2 * 1024 * 1024), // 2 MiB per request
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be made configurable?

static function (ServerRequestInterface $request) use ($twigRenderer, &$counter): Response|Promise {
$headers = [
'Content-Type' => 'application/json',
'Access-Control-Allow-Origin' => '*',
];
$msgs = [];
++$counter;
$method = $request->getMethod();
$query = $request->getQueryParams();
$body = $request->getBody()->getContents();

try {
$body = json_decode($body ?: '{}', true, 512, JSON_THROW_ON_ERROR);
} catch (\Exception $exception) {
// @todo why doesn't this catch errors from malformed JSON?
$msgs[] = 'Not able to parse JSON. '.$exception->getMessage();

return new Response(400, $headers, formatResponseBody($msgs));
}

if (!isset($query['type'])) {
return new Response(
200,
202,
$headers,
json_encode([
'ok' => true,
'info' => $twigRenderer->getInfo(),
'meta' => [
'counter' => $counter,
'query' => $query,
'body' => $body,
'method' => $method,
],
], JSON_THROW_ON_ERROR)
'message' => "No action correctly requested. Url must have a query param of 'templatePath' for which twig template to render, but yes - the server is running.",
])
);
}

case 'renderFile':
return new Promise(static function ($resolve, $reject) use ($twigRenderer, $body, $headers): void {
$results = $twigRenderer->render($body['template'], $body['data']);
$response = new Response(
$results['ok'] ? 200 : 404,
$headers,
json_encode($results, JSON_THROW_ON_ERROR)
);
$resolve($response);
});

case 'renderString':
return new Promise(static function ($resolve, $reject) use ($twigRenderer, $body, $headers): void {
$results = $twigRenderer->renderString($body['template'], $body['data']);
$response = new Response(
$results['ok'] ? 200 : 404,
// one of: meta, renderFile, renderString
$type = $query['type'];

switch ($type) {
case 'meta':
return new Response(
200,
$headers,
json_encode($results, JSON_THROW_ON_ERROR)
json_encode([
'ok' => true,
'info' => $twigRenderer->getInfo(),
'meta' => [
'counter' => $counter,
'query' => $query,
'body' => $body,
'method' => $method,
],
], JSON_THROW_ON_ERROR)
);
$resolve($response);
});

case 'renderFile':
return new Promise(static function ($resolve, $reject) use ($twigRenderer, $body, $headers): void {
$results = $twigRenderer->render($body['template'], $body['data']);
$response = new Response(
$results['ok'] ? 200 : 404,
$headers,
json_encode($results, JSON_THROW_ON_ERROR)
);
$resolve($response);
});

case 'renderString':
return new Promise(static function ($resolve, $reject) use ($twigRenderer, $body, $headers): void {
$results = $twigRenderer->renderString($body['template'], $body['data']);
$response = new Response(
$results['ok'] ? 200 : 404,
$headers,
json_encode($results, JSON_THROW_ON_ERROR)
);
$resolve($response);
});
}
}
});
);

$context = [];
$uri = sprintf('127.0.0.1:%u', $port);
Expand Down