New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace Orientation input enum with a string set type #32

Open

olistrik wants to merge 1 commit into main from use-types-rather-than-enums-for-orientation-input

Contributor

olistrik commented Aug 16, 2023 •

edited

Loading

I also extracted the variant to an exported type.

this will break existing usages of radio buttons.

olistrik force-pushed the use-types-rather-than-enums-for-orientation-input branch from 101bdb2 to a5bc400 Compare

August 16, 2023 09:32


          fix: replace Orientation input enum with a string set type

57f4c62

olistrik force-pushed the use-types-rather-than-enums-for-orientation-input branch from a5bc400 to 57f4c62 Compare

August 16, 2023 10:03

olistrik requested a review from wouter-willems

August 16, 2023 10:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet