Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the WebAssembly build #170

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix the WebAssembly build #170

merged 2 commits into from
May 24, 2024

Conversation

jerbob92
Copy link
Contributor

Accidentally a import "C" was added to the WebAssembly implementation. When you then have no CGO available in your environment, the build fails. I have also added some extra steps to catch this in the CI process next time.

Fixes #169

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (17f2263) to head (e5db754).
Report is 2 commits behind head on main.

Current head e5db754 differs from pull request most recent head d8ff969

Please upload reports for the commit d8ff969 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files         110      110           
  Lines       18942    18942           
=======================================
  Hits        14803    14803           
  Misses       2358     2358           
  Partials     1781     1781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jerbob92 jerbob92 merged commit ca60183 into main May 24, 2024
27 of 33 checks passed
@jerbob92 jerbob92 deleted the feature/fix-webassembly branch May 24, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web assembly implementation build error after v1.12.0 upgrade
1 participant