Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pdfium to 6392, implement new methods #152

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jerbob92
Copy link
Contributor

@jerbob92 jerbob92 commented Apr 2, 2024

This updates pdfium to version 6392 and implements the following new experimental methods:

  • FPDFAnnot_AddFileAttachment
  • FPDFAnnot_GetFileAttachment

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 79.22078% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 78.14%. Comparing base (fc9a455) to head (5c9cdfa).

Files Patch % Lines
internal/implementation_webassembly/fpdf_annot.go 76.19% 5 Missing and 5 partials ⚠️
internal/implementation_cgo/fpdf_annot.go 82.85% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   78.13%   78.14%   +0.01%     
==========================================
  Files         110      110              
  Lines       18865    18942      +77     
==========================================
+ Hits        14740    14803      +63     
- Misses       2352     2358       +6     
- Partials     1773     1781       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jerbob92 jerbob92 merged commit 0fc63a9 into main Apr 2, 2024
35 checks passed
@jerbob92 jerbob92 deleted the feature/upgrade-pdfium-to-6392 branch April 2, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant