Merge pull request #446 from jimni1222/bn

Added logic to handle decimal points in BigNumber
klaytn · Apr 9, 2021 · b1b916a · b1b916a
2 parents 52035b7 + 2831ae3
commit b1b916a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/caver-utils/src/index.js b/packages/caver-utils/src/index.js
@@ -304,6 +304,10 @@ const toPeb = function(number, unit) {
 
     unit = getUnitValue(unit)
 
+    // BigNumber can support decimal points but BN does not support.
+    // So if BigNumber type number is came as a parameter,
+    // use `toString` function of BigNumber to prevent error while converting BigNumber to BN.
+    if (utils.isBigNumber(number)) number = number.toString()
     if (!utils.isBN(number) && !_.isString(number)) {
         number = tryNumberToString(number)
     }

diff --git a/test/packages/caver.utils.js b/test/packages/caver.utils.js
@@ -1989,6 +1989,13 @@ describe('caver.utils.convertToPeb', () => {
 
         expect(_.isString(converted)).to.be.true
         expect(converted === expected).to.be.true
+
+        const expectedForDecimalPoints = '2500000000000000000'
+
+        const convertingDecimalPoint = caver.utils.convertToPeb(new BigNumber(2.5), 'KLAY')
+
+        expect(_.isString(convertingDecimalPoint)).to.be.true
+        expect(convertingDecimalPoint === expectedForDecimalPoints).to.be.true
     })
 
     it('CAVERJS-UNIT-ETC-244: should convert to peb from kKLAY', () => {