Merge pull request #11 from showpad/spread-on-promise-alternative

Spread on promise alternative

CHANGELOG.md

@@ -1,5 +1,8 @@
 # angular-q-spread changelog
 
+### 1.1.0
+* Add `spread` on every promise
+
 ### 1.0.4 
 * Use minified version in bower config
 

README.md

@@ -7,11 +7,13 @@
 angular-q-spread
 ================
 
-Add `spread` method to the promise returned by $q.all.
+Add `spread` method to all promises created by the $q service.
 
 `spread` can be used as a replacement for `then`. Similarly, it takes two parameters, a callback when all promises are resolved and a callback for failure.
 The resolve callback is going to be called with the result of the list of promises passed to $q.all as separate parameters instead of one parameters which is an array.
 
+`spread` can be chained onto every promise.
+
 #Compatibility
 This plugin has been tested with Angular 1.2 and 1.3
 

bower.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-q-spread",
-  "version": "1.0.4",
+  "version": "1.1.0",
   "homepage": "https://github.com/showpad/angular-q-spread",
   "description": "Add `spread` method to the promise of $q.all",
   "main": "dist/q-spread.min.js",

dist/q-spread.js

@@ -7,29 +7,29 @@
 
             $provide.decorator('$q', ['$delegate', function ($delegate) {
 
-                var originalAll = $delegate.all;
-
-                $delegate.all = function (promises) {
-                    var promise = originalAll(promises);
-
-                    /**
-                     * Spread method, proxies to `then` but spreads the results for the resolve callback
-                     * @param {Function} resolve
-                     * @param {Function} reject
-                     */
-                    promise.spread = function (resolve, reject) {
-
-                        function spread(data) {
-                            return resolve.apply(void 0, data);
-                        }
-
-                        return promise.then(spread, reject);
-                    };
-
-                    return promise;
+                var originalDefer = $delegate.defer;
+
+                $delegate.defer = function () {
+                    // Get the prototype of the promise
+                    var promiseProto = originalDefer().promise.constructor.prototype;
+
+                    // Add the spread method
+                    Object.defineProperty(promiseProto, 'spread', {
+                        value: function (resolve, reject) {
+                            function spread (data) {
+                                return resolve.apply(void 0, data);
+                            }
+
+                            return this.then(spread, reject);
+                        },
+                        writable: true,
+                        enumerable: false
+                    });
+                    
+                    return originalDefer();
                 };
 
                 return $delegate;
             }]);
         }]);
-})(window.angular);
+})(window.angular);

gulpfile.js

@@ -21,7 +21,10 @@ gulp.task('karma', function (done) {
             configFile: config.test,
             singleRun: true
         },
-        done
+        function () {
+            done();
+        }
+
     );
 
     server.start();

package.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-q-spread",
-  "version": "1.0.4",
+  "version": "1.1.0",
   "description": "Add `spread` method to the promise of $q.all",
   "main": "index.js",
   "scripts": {

src/q-spread.js

@@ -7,29 +7,29 @@
 
             $provide.decorator('$q', ['$delegate', function ($delegate) {
 
-                var originalAll = $delegate.all;
-
-                $delegate.all = function (promises) {
-                    var promise = originalAll(promises);
-
-                    /**
-                     * Spread method, proxies to `then` but spreads the results for the resolve callback
-                     * @param {Function} resolve
-                     * @param {Function} reject
-                     */
-                    promise.spread = function (resolve, reject) {
-
-                        function spread(data) {
-                            return resolve.apply(void 0, data);
-                        }
-
-                        return promise.then(spread, reject);
-                    };
-
-                    return promise;
+                var originalDefer = $delegate.defer;
+
+                $delegate.defer = function () {
+                    // Get the prototype of the promise
+                    var promiseProto = originalDefer().promise.constructor.prototype;
+
+                    // Add the spread method
+                    Object.defineProperty(promiseProto, 'spread', {
+                        value: function (resolve, reject) {
+                            function spread (data) {
+                                return resolve.apply(void 0, data);
+                            }
+
+                            return this.then(spread, reject);
+                        },
+                        writable: true,
+                        enumerable: false
+                    });
+                    
+                    return originalDefer();
                 };
 
                 return $delegate;
             }]);
         }]);
-})(window.angular);
+})(window.angular);