Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: fix deployer Dockerfile #1512

Merged
merged 6 commits into from
Oct 21, 2024
Merged

dev: fix deployer Dockerfile #1512

merged 6 commits into from
Oct 21, 2024

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Oct 18, 2024 •
edited
Loading

Fixes issues with deployer Dockerfile:

  • .env must be copied
  • issues when building sol contracts due to starknet -> Starknet capitalization

This change is Reviewable

@enitrat enitrat force-pushed the dev/dockerfile-path-uv branch 2 times, most recently from 673c1c2 to 007460e Compare October 18, 2024 18:35
@enitrat
# This is a combination of 2 commits.
8045510 
# This is the 1st commit message:

dev: add cargo binaries to PATH in Dockerfile

# This is the commit message #2:

fix: Dockerfile build
@enitrat
fix
e4a1217 
tmp
@enitrat
fix
78f145f
@ClementWalter ClementWalter merged commit b8f5f2a into main Oct 21, 2024
14 checks passed
@ClementWalter ClementWalter deleted the dev/dockerfile-path-uv branch October 21, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementWalter ClementWalter ClementWalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @ClementWalter