Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass visitorData to requests #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jdesgats
Copy link

@jdesgats jdesgats commented Jan 21, 2025

Description

Pass visitorData to requests emitted by the client.

This is a nearly verbatim copy of a similar PR from NewPipe as it is also affected by the same issue, for now the code is pretty rough and I'm not even sure that this data should be passed for all requests but it does seem to unblock the iOS client for now.

Issues to fix

Please link issues this PR will fix: #354

Reminding

Something you can do before PR to reduce time to merge

  • run "make build" to build the code
  • run "make format" to reformat the code
  • run "make lint" if you are using unix system
  • run "make test-integration" to pass all tests

This is a nearly verbatim copy of [1], for now the code is pretty rough and
I'm not even sure that this data should be passed for all requests but it
does seem to unblock the iOS client for now.

[1] TeamNewPipe/NewPipeExtractor#1262
@d0rc
Copy link

d0rc commented Jan 22, 2025

I've tested it, and it works exactly as expected. Thank you! @jdesgats

@dakolli
Copy link

dakolli commented Jan 23, 2025

Can we merge this please.

@shoce
Copy link

shoce commented Jan 24, 2025

@corny can we please merge this?

@shoce
Copy link

shoce commented Jan 27, 2025

i tested it too and it really unblocks iOS client, i can download again without 403 errors.

@corny can we please have it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected status code: 403
4 participants