Add reports to user-admin panel #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kjcioffi
commented
Jul 25, 2024
kjcioffi
commented
- Added 3 kinds of reports
- Customer
- Product
- Sales
- Reports can be downloaded in CSV or PDF format.
- Add column for displaying percentage of order. - Add dollar signs and other symbols to better describe the data. - Add store name into the file name.
kjcioffi
added this to the Deploy enhanced version of Django E-commerce webapp milestone
Closed
3 tasks
ryaustin
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
This is totally rad!
Now with reporting using csv and pdfs this app is shaping up to a very useful saas tool
- reports are working
- no regression possible
- we can discuss how to test this particularly pdfs
- we can think about refactoring later such as reducing some repetition but not essential today.
I'm happy that you raised the alarm and stuck through this problem!
| @@ -0,0 +1,21 @@ | |||
| {% extends "store/base.html" %} | |||
There was a problem hiding this comment.
you might consider creating reports_base.html. This is so that you can set reports up independent of the base.html with its navigation etc that will not make much sense on a pdf report.
We see from he weasyprint documentation that using @page we can create a block rules that weasyprint will respond to. A practical example could be
- setting the page size and orientation (which can also be passed in as variables in the context data).
- setting up headers and footers so that reports look consistent
Here's an example of a reports_base.html taken from bits and pieces of their documentation and a bit of regular html/django:
{% load static %}
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Report {% block title %} {% endblock %}</title>
<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet"
integrity="sha384-rbsA2VBKQhggwzxH7pPCaAqO46MgnOM80zW1RWuH61DGLwZJEdK2Kadq2F9CUG65" crossorigin="anonymous">
<link rel="stylesheet" href="{% static 'css/reports/reports_base.css' %}">
<style>
@page {
size: letter Portrait;
margin: 1in;
font-family: 'Roboto', 'Arial', sans-serif;
@bottom-left {
content: 'Contempo Crafts';
font-size: x-small;
}
@bottom-center {
content: "Page " counter(page) " of " counter(pages);
font-size: x-small;
}
@bottom-right {
content: '{{report_date | default_if_none:""}} {{report_name}}';
font-size: x-small;
}
}
</style>
{% block styles %}{% endblock %}
</head>
There was a problem hiding this comment.
I wasn't aware these features existed, thanks! I will add this suggestion to #3 for my sanity as this seems more related to that issue. That way I can also close and complete this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.