-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use local images in dev instead of published ones #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev compose should be building locally instead of using public images (built of main
)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 63.30% 63.30%
=======================================
Files 14 14
Lines 278 278
Branches 25 25
=======================================
Hits 176 176
Misses 99 99
Partials 3 3 ☔ View full report in Codecov by Sentry. |
So, I should replace the image names with a |
Yep |
rename PR please |
Rationale
use
kiwix
as organization name instead ofopenzim
in dev docker-composeChanges
image: openzim/mirrors-qa-backend
withimage: kiwix/mirrors-qa-backend
image: openzim/mirrors-qa-worker-manager
withimage: kiwix/mirrors-qa-worker-manager