Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use local images in dev instead of published ones #18

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

elfkuzco
Copy link
Collaborator

Rationale

use kiwix as organization name instead of openzim in dev docker-compose

Changes

  • replace image: openzim/mirrors-qa-backend with image: kiwix/mirrors-qa-backend
  • replace image: openzim/mirrors-qa-worker-manager with image: kiwix/mirrors-qa-worker-manager

@elfkuzco elfkuzco requested a review from rgaudin June 12, 2024 10:01
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev compose should be building locally instead of using public images (built of main)

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.30%. Comparing base (0181ad1) to head (a6ad9ca).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   63.30%   63.30%           
=======================================
  Files          14       14           
  Lines         278      278           
  Branches       25       25           
=======================================
  Hits          176      176           
  Misses         99       99           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elfkuzco
Copy link
Collaborator Author

dev compose should be building locally instead of using public images (built of main)

So, I should replace the image names with a build directive instead?

@rgaudin
Copy link
Member

rgaudin commented Jun 12, 2024

Yep

@elfkuzco elfkuzco requested a review from rgaudin June 12, 2024 10:18
@rgaudin
Copy link
Member

rgaudin commented Jun 12, 2024

rename PR please

@elfkuzco elfkuzco changed the title use kiwix as org name instead of openzim use local images in dev instead of public Jun 12, 2024
@elfkuzco elfkuzco changed the title use local images in dev instead of public use local images in devevelopment instead of public Jun 12, 2024
@elfkuzco elfkuzco changed the title use local images in devevelopment instead of public use local images in devevelopment instead of published ones Jun 12, 2024
@elfkuzco elfkuzco changed the title use local images in devevelopment instead of published ones use local images in dev instead of published ones Jun 12, 2024
@elfkuzco elfkuzco merged commit 7504c67 into main Jun 12, 2024
3 checks passed
@elfkuzco elfkuzco deleted the update-docker-compose branch June 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants