Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve basic repo architecture #15

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Improve basic repo architecture #15

merged 5 commits into from
Jun 7, 2024

Conversation

elfkuzco
Copy link
Collaborator

@elfkuzco elfkuzco commented Jun 6, 2024

Rationale

Improve basic repository structure with stub implementations of features. This resolves #14

Changes

  • Set up working FastAPI server
  • Count list of mirrors on backend startup
  • Make database migrations on backend startup
  • Set up a worker manager that sleeps at intervals after doing a dummy task
  • Set up a working docker compose for development
  • Add workflow to publish docker images
  • Combine QA for all subprojects into one workflow and separate jobs using dorny/paths-filter

@elfkuzco elfkuzco requested a review from rgaudin June 6, 2024 13:16
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ;

Please see inline comments ;

Also please use meaningful names for you branches and dont reuse the same one always.

On the dev compose, this can be a future task, but we've seen that those static docker images are not that practical and it's more convenient to use tweaked images that mount the project root and run fastapi in dev mode (reload). Allows having everything docker-setup (like the DB) but still have the convenience of hot-reload.

.github/workflows/Publish.yaml Outdated Show resolved Hide resolved
backend/Dockerfile Outdated Show resolved Hide resolved
backend/Dockerfile Outdated Show resolved Hide resolved
backend/docker-entrypoint.sh Outdated Show resolved Hide resolved
backend/src/mirrors_qa_backend/settings.py Outdated Show resolved Hide resolved
dev/docker-compose.yaml Outdated Show resolved Hide resolved
dev/postgres-initdb/init-extensions.sh Show resolved Hide resolved
worker/docker-entrypoint.sh Outdated Show resolved Hide resolved
backend/Dockerfile Outdated Show resolved Hide resolved
worker/src/mirrors_qa_worker/manager/worker.py Outdated Show resolved Hide resolved
@elfkuzco elfkuzco requested a review from rgaudin June 6, 2024 20:24
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
Regarding workflows, please use the Github action filter directly.

.github/workflows/backend-Publish.yaml Outdated Show resolved Hide resolved
.github/workflows/backend-Publish.yaml Outdated Show resolved Hide resolved
.github/workflows/backend-Publish.yaml Outdated Show resolved Hide resolved
.github/workflows/worker-QA.yaml Outdated Show resolved Hide resolved
.github/workflows/worker-QA.yaml Outdated Show resolved Hide resolved
.github/workflows/worker-manager-Publish.yaml Outdated Show resolved Hide resolved
@elfkuzco elfkuzco requested a review from rgaudin June 7, 2024 16:45
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@elfkuzco elfkuzco merged commit b58f624 into main Jun 7, 2024
2 checks passed
@elfkuzco elfkuzco deleted the dev branch June 7, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic repo architecture/2
2 participants