-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve basic repo architecture #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ;
Please see inline comments ;
Also please use meaningful names for you branches and dont reuse the same one always.
On the dev compose, this can be a future task, but we've seen that those static docker images are not that practical and it's more convenient to use tweaked images that mount the project root and run fastapi in dev mode (reload). Allows having everything docker-setup (like the DB) but still have the convenience of hot-reload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Regarding workflows, please use the Github action filter directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Rationale
Improve basic repository structure with stub implementations of features. This resolves #14
Changes
dorny/paths-filter