Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set up basic repo structure #13

Merged
merged 10 commits into from
Jun 5, 2024
Merged

set up basic repo structure #13

merged 10 commits into from
Jun 5, 2024

Conversation

elfkuzco
Copy link
Collaborator

@elfkuzco elfkuzco commented May 31, 2024 •
edited
Loading

Changes

@rgaudin rgaudin self-requested a review June 3, 2024 07:32
rgaudin
rgaudin requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elfkuzco thank you!

On the PR itself, please use the Development section on the GH sidebar to mark the issue(s) that are fixed by the PR and should be closed automatically by GH on merge (or use appropriate wording in PR description).

Just looking at your PR title and description does not help understand if any ticket is fixed or if this contains contributions to several tickets.

Please read my comments and suggestions inline.

backend/pyproject.toml Outdated Show resolved Hide resolved
backend/src/backend/migrations/script.py.mako Outdated Show resolved Hide resolved
backend/src/backend/enums.py Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
This was linked to issues Jun 3, 2024
Basic repo architecture #5
Closed
Database schema #6
Closed
Update mirrors DB #12
Closed
@elfkuzco elfkuzco removed a link to an issue Jun 4, 2024
Update mirrors DB #12
Closed
@elfkuzco elfkuzco requested a review from rgaudin June 4, 2024 09:54
rgaudin
rgaudin requested changes Jun 4, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there!

backend/src/backend/db/models.py Outdated Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
backend/src/backend/db/models.py Outdated Show resolved Hide resolved
@elfkuzco elfkuzco requested a review from rgaudin June 4, 2024 11:17
rgaudin
rgaudin approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 ; please remove the CHANGELOG then merge to main.

That's not exactly what I was expecting for #13 but it's OK. I opened #14 as follow-up. With #14 we should be able to have all the setup stuff in place and focus on the actual features.

CHANGELOG.md Outdated Show resolved Hide resolved
@rgaudin rgaudin mentioned this pull request Jun 4, 2024
Closed
@elfkuzco elfkuzco merged commit d8c7b37 into main Jun 5, 2024
2 checks passed
@elfkuzco elfkuzco deleted the dev branch June 5, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database schema Basic repo architecture
2 participants
@elfkuzco @rgaudin