-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added nofilter attribute and iframe conditions #587
Conversation
Codecov Report
@@ Coverage Diff @@
## master #587 +/- ##
=======================================
Coverage 64.92% 64.92%
=======================================
Files 53 53
Lines 3738 3738
Branches 1881 1881
=======================================
Hits 2427 2427
Misses 1309 1309
Partials 2 2 Continue to review full report at Codecov.
|
To include a widget on the MediaWiki server we will require https://www.mediawiki.org/wiki/Extension:Iframe, and to make it a bit responsive we need to use |
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
@MananJethwani Is this PR a draft or ready to be reviewed ? |
@mgautierfr it's still a draft, @kelson42 asked me too test it on a wiki but for some reason I am not able to use widget extension for mediawiki as of now....will have a look in some time after solving some other tickets. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
@juuz0 Please consider this PR. We will have to decide if hidding completly the top searchbar should be done like this via a parameter, or this can be done easily, just by customising the CSS of iframe HTML (to me sounds preferable). |
this resolves #585