Dummy PR for Adding selenium ui test #1296

THEBOSS0369 · 2024-12-06T13:34:10Z

This PR is a Dummy PR for Adding selenium ui test and is successor of PR #1286 created for ensuring tests passing or not in browser stack.

THEBOSS0369 · 2024-12-24T15:01:45Z

I will be resuming my work on this issue Now. Thanks for your patience 😃

…itest

THEBOSS0369 · 2025-01-10T04:52:31Z

U were right sir, The error is something else, the popup still shows up in testing

Jaifroid · 2025-01-10T06:47:18Z

Unfortunately, Edge Legacy isn't fixed, the Promise code didn't work, merely masked the errors because the script ended prematurely. BrowserStack videos show that the last test still timed out.

This reverts commit d123a2a.

This reverts commit 984fa47.

This reverts commit da557df.

THEBOSS0369 · 2025-01-10T07:00:27Z

Unfortunately, Edge Legacy isn't fixed, the Promise code didn't work, merely masked the errors because the script ended prematurely. BrowserStack videos show that the last test still timed out.

Oh no, I didn't noticed that.

Jaifroid · 2025-01-10T07:16:27Z

So I'm reverting changes tried so far and now trying to increase timeouts to solve Edge Legacy test first. Then we can look at Firefox 70, though I won't get to that till the weekend.

THEBOSS0369 · 2025-01-10T07:36:29Z

So I'm reverting changes tried so far and now trying to increase timeouts to solve Edge Legacy test first. Then we can look at Firefox 70, though I won't get to that till the weekend.

No problem sir

Jaifroid · 2025-01-10T08:01:33Z

Maximum timeout of 300 seconds isn't sufficient. So we need now to restructure the tests so that the window isn't opened and left idling before receiving any commands. The approaches tried to make this happen so far haven't worked because runTests isn't fully async, so synchronous parts of the tests get executed immediately even when chained within Promises.

Restructuring this is more involved than I can do today, so this will have to wait. In the meantime, I've disabled all BS tests except Edge Legacy so we can focus on that one.

This reverts commit d9db9d3.

Jaifroid · 2025-01-10T12:07:23Z

So, I solved the Edge Legacy tests by running them in a single driver, so that the other drivers are not hanging around waiting for tests to complete. This works fine and the pattern in https://github.com/kiwix/kiwix-js/blob/selenium-uitest/tests/e2e/runners/edge/edge18.bs.runner.js#L40 can be used in other cases where we have any timeout issue.

I also added stronger prevention of the security popup in 6178c1c, so that shouldn't bother you now.

You may find that the issue in Firefox 70 is now fixed. In any case, you can now go ahead and test that!

Fingers crossed.... 🤞

Jaifroid · 2025-01-10T12:13:18Z

tests/e2e/spec/tonedear.e2e.spec.js

+                        const swRegistration = await driver.executeScript('return navigator.serviceWorker.ready');
+                        assert.ok(swRegistration, 'Service Worker is registered');
+
+                        console.log('Current URL:', await driver.getCurrentUrl());


Just a reminder to remove test logging once no longer needed.

THEBOSS0369 · 2025-01-10T15:21:21Z

So, I solved the Edge Legacy tests by running them in a single driver, so that the other drivers are not hanging around waiting for tests to complete. This works fine and the pattern in https://github.com/kiwix/kiwix-js/blob/selenium-uitest/tests/e2e/runners/edge/edge18.bs.runner.js#L40 can be used in other cases where we have any timeout issue.

I also added stronger prevention of the security popup in 6178c1c, so that shouldn't bother you now.

You may find that the issue in Firefox 70 is now fixed. In any case, you can now go ahead and test that!

Fingers crossed.... 🤞

@Jaifroid Sir Thanks for fixing the tests, that dialog box error is fixed now in my local server. I'm commenting out the ff70's test for tonedear let's see if it passes this time or not.

Jaifroid · 2025-01-10T15:45:23Z

tests/e2e/spec/tonedear.e2e.spec.js

+                try {
+                    const activeAlertModal = await driver.findElement(By.css('.modal[style*="display: block"]'));
+                    if (activeAlertModal) {
+                        serviceWorkerAPI = await driver.findElement(By.id('modalLabel')).getText().then(function (alertText) {
+                            return !/ServiceWorker\sAPI\snot\savailable/i.test(alertText);
+                        });
+                        const approveButton = await driver.wait(until.elementLocated(By.id('approveConfirm')));
+                        await approveButton.click();
+                    }
+                } catch (e) {
+                    // Do nothing
+                }


@THEBOSS0369 I think you could remove these lines. Although it's not the cause of the current error, it will never now find this element, and it introduces overhead (and confusion about the cause of failure in the logs). I'll test on a local copy of FF70 to see if there's an obvious cause of the failure to navigate to the Audio app page.

Jaifroid · 2025-01-10T15:54:41Z

OK, I reproduce the error in my local copy of FF70 (via PortableApps). The problem appears to be more generic: an incompatibility in the Zimit wombat setup script. It seems replaceAll isn't supported in this version of Firefox. See screenshot.

Jaifroid · 2025-01-10T15:57:14Z

Indeed, replaceAll isn't supported in FF < 77:

https://caniuse.com/?search=replaceAll

I can't remember, but I think we polyfill it in legacy MS browsers. Will check.

Jaifroid · 2025-01-10T16:05:02Z

OK, this file wombatSetup.js is loaded inside the ZIM, so we can't easily polyfill it. It's just an incompatibility with Firefox < 77 when running Zimit archives.

What I suggest is that you run the test only in jQuery (Restricted) mode for the FF70 test, as we know that's passing, and we can't work around this error. Nothing to do with your test, Zimit archives will just fail in FF < 77, and users should switch to Restricted mode. I'll see if I can fix that as an automatic switch, but it's another issue.

So, please don't spend more time on this, just run this tonedear test (the FF70 one) only in jQuery mode.

THEBOSS0369 · 2025-01-10T16:13:44Z

100% Agree sir I was also thinking the same way but I was thinking that we should skip the Verification of Images only in ff70 as all other tests are passing in sw mode except this. Let me know whether we should skip the verification of images test specifically for sw mode or should we follow as you suggested.

Also I will be able to do the changes tomorrow morning.

Jaifroid · 2025-01-10T16:39:50Z

100% Agree sir I was also thinking the same way but I was thinking that we should skip the Verification of Images only in ff70 as all other tests are passing in sw mode except this. Let me know whether we should skip the verification of images test specifically for sw mode or should we follow as you suggested.

Also I will be able to do the changes tomorrow morning.

No, I think we should skip the test in SW mode completely in FF70, because it's not a valid test if the app just can't navigate to any other page than the home page (which is the case). It would be more meaningful to skip SW mode in this browser (for tonedear) because it also gives a signal to devs that the browser doesn't actually support Zimit archives in SW mode. If you like you could add a comment in the code to explain why we skip it in that browser.

…r FF70 Test

THEBOSS0369 · 2025-01-11T05:11:51Z

@Jaifroid Got it sir, that makes sense. I have removed the extra code lines and changed the code for test to skip sw mode for tonedear. i'm waiting for the tests to pass. Once these test passes i will copy the codes in the main PR from where we started.

Adding selenium ui test

d26d69b

THEBOSS0369 added 28 commits December 25, 2024 09:54

Merge branch 'main' into selenium-uitest

8ec21d3

Testing

d303ac3

Merge remote-tracking branch 'origin/selenium-uitest' into selenium-u…

93356f2

…itest

Testing

0647493

Testing

487edc2

Testing

744e08d

Testing

065824e

Testing 8

1ffee45

Testing 9

d4e5702

Testing 9

1833190

testing 11

e094798

Testing 12

1c5f3a5

Testing 13

cde4771

Testing 14

cff2d2c

Testing 15

1a767e0

Testing 16

32d7a30

Testing 17

a6b0b17

Testing 18

4ae5d21

Testing 19 starting from start

b28dff5

Testing 20

b19198f

Testing 21

33cbd3c

Testing 22 coming close

2a18cdb

Testing 23 coming close

d9e7392

Testing 24

0499f26

Testing 25 more close

ee74423

Testing 25 more close

1ee1e15

Adding firefox 70 tests to see it passes or not

c40a1c0

Adding firefox 70 tests to see it passes or not

752a080

Jaifroid added 3 commits January 10, 2025 06:54

Revert "Adding Tonedear Test in FF70 for verification"

f73bfeb

This reverts commit d123a2a.

Revert "Use Promises"

5d838ea

This reverts commit 984fa47.

Revert "Do not load drivers too soon"

a3eac1c

This reverts commit da557df.

Try timeout approach

61deb0d

Jaifroid added 2 commits January 10, 2025 07:41

Correct the syntax

218185e

Temporarily disabling all BS tests except Edge

d9db9d3

Jaifroid added 3 commits January 10, 2025 11:33

Use single driver for Edge Legacy tests

c643066

Ensure source verification is switched off with noPrompts

6178c1c

Revert "Temporarily disabling all BS tests except Edge"

b900c46

This reverts commit d9db9d3.

Jaifroid reviewed Jan 10, 2025

View reviewed changes

Commented out the console log

16bd5f7

Commenting out the tonedear tests for FF70

32eca48

Jaifroid reviewed Jan 10, 2025

View reviewed changes

Jaifroid mentioned this pull request Jan 10, 2025

Firefox < 77 cannot navigate in Zimit files due to lack of support for replaceAll() #1300

Open

Removing unnecessary lines of codes and allowing only J Query mode fo…

eccdd97

…r FF70 Test

THEBOSS0369 mentioned this pull request Jan 11, 2025

Added an automated Selenium UI test for a small Zimit2 archive #1286

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dummy PR for Adding selenium ui test #1296

Dummy PR for Adding selenium ui test #1296

THEBOSS0369 commented Dec 6, 2024

THEBOSS0369 commented Dec 24, 2024

THEBOSS0369 commented Jan 10, 2025 •

edited

Loading

Jaifroid commented Jan 10, 2025

THEBOSS0369 commented Jan 10, 2025

Jaifroid commented Jan 10, 2025

THEBOSS0369 commented Jan 10, 2025

Jaifroid commented Jan 10, 2025 •

edited

Loading

Jaifroid commented Jan 10, 2025

Jaifroid Jan 10, 2025

THEBOSS0369 Jan 10, 2025

THEBOSS0369 commented Jan 10, 2025

Jaifroid Jan 10, 2025

Jaifroid commented Jan 10, 2025

Jaifroid commented Jan 10, 2025

Jaifroid commented Jan 10, 2025 •

edited

Loading

THEBOSS0369 commented Jan 10, 2025 •

edited

Loading

Jaifroid commented Jan 10, 2025

THEBOSS0369 commented Jan 11, 2025

Dummy PR for Adding selenium ui test #1296

Are you sure you want to change the base?

Dummy PR for Adding selenium ui test #1296

Conversation

THEBOSS0369 commented Dec 6, 2024

THEBOSS0369 commented Dec 24, 2024

THEBOSS0369 commented Jan 10, 2025 • edited Loading

Jaifroid commented Jan 10, 2025

THEBOSS0369 commented Jan 10, 2025

Jaifroid commented Jan 10, 2025

THEBOSS0369 commented Jan 10, 2025

Jaifroid commented Jan 10, 2025 • edited Loading

Jaifroid commented Jan 10, 2025

Jaifroid Jan 10, 2025

Choose a reason for hiding this comment

THEBOSS0369 Jan 10, 2025

Choose a reason for hiding this comment

THEBOSS0369 commented Jan 10, 2025

Jaifroid Jan 10, 2025

Choose a reason for hiding this comment

Jaifroid commented Jan 10, 2025

Jaifroid commented Jan 10, 2025

Jaifroid commented Jan 10, 2025 • edited Loading

THEBOSS0369 commented Jan 10, 2025 • edited Loading

Jaifroid commented Jan 10, 2025

THEBOSS0369 commented Jan 11, 2025

THEBOSS0369 commented Jan 10, 2025 •

edited

Loading

Jaifroid commented Jan 10, 2025 •

edited

Loading

Jaifroid commented Jan 10, 2025 •

edited

Loading

THEBOSS0369 commented Jan 10, 2025 •

edited

Loading