replaced localStorage with settingsStore method #1185
Conversation
|
@Greeshmanth1909 Thanks for your PR. I'll review shortly. |
|
what went wrong and can I please know how to replicate this error? |
|
Probably just a temporary error. Tests can be a bit unstable if there's a lot of load on the system. I'll re-run. |
|
Got it, thanks! |
|
@Jaifroid Are there any more tests? |
No, just a few manual ones from me. I'll do those now. |
|
Just to confirm that it works fine in IE11. |
|
My other manual tests are all fine. I'll review code now. |
There was a problem hiding this comment.
The changes all look good, many thanks @Greeshmanth1909! Also many thanks for listing all the testing you've done, it really helps to know where I need to concentrate my own testing. Please ignore the one comment on the code, this is just a note to self about a possible separate issue unrelated to this PR.
Let me know when you're happy for me to squash/merge. You will appear as the PR author.
| @@ -234,7 +235,7 @@ function loadPreviousZimFile () { | |||
| // It's a bit hacky but it works and I am not sure if there is any other way ATM | |||
| setTimeout(() => { | |||
| if (window.params.isFileSystemApiSupported || window.params.isWebkitDirApiSupported) { | |||
| const filenames = localStorage.getItem('zimFilenames'); | |||
| const filenames = settingsStore.getItem('zimFilenames'); | |||
| if (filenames) updateZimDropdownOptions(filenames.split('|'), ''); | |||
| } | |||
| }, 200); | |||
There was a problem hiding this comment.
This is just a note to self, not part of this PR, but this timeout may well be the problem with inconsistency in loading the contents of archives. It introduces a race condition, and needs looking at as a separate issue.
|
@Jaifroid Thats great! Please go ahead and merge the PR. |
resolves #1171
As the title says, replaced localStorage method with settingsStore method.
Heres a list of tests I performed:
npm run serveandnpm run previewand tested for chrome and firefox in both Jquery and serviceWorker modes.npm testall tests were successfulIn all the tests, I was able to open the application and view .zim files. I also checked the localStorage and verified the presence of
kiwixjs-prefix.