[REFACTOR] Final changes asked by @Jaifroid

kiwix · Sep 19, 2023 · 585ee86 · 585ee86
1 parent 2f0def7
commit 585ee86
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/www/js/app.js b/www/js/app.js
@@ -381,7 +381,6 @@ document.getElementById('btnConfigure').addEventListener('click', function (even
     document.getElementById('liAboutNav').setAttribute('class', '');
     $('.navbar-collapse').collapse('hide');
     // Show the selected content in the page
-    // uiUtil.removeAnimationClasses();
 
     uiUtil.tabTransitionToSection('config', params.showUIAnimations);
 
@@ -398,8 +397,8 @@ document.getElementById('btnAbout').addEventListener('click', function (event) {
     document.getElementById('liConfigureNav').setAttribute('class', '');
     document.getElementById('liAboutNav').setAttribute('class', 'active');
     $('.navbar-collapse').collapse('hide');
+
     // Show the selected content in the page
-    // uiUtil.removeAnimationClasses();
     uiUtil.tabTransitionToSection('about', params.showUIAnimations);
 
     // Use a timeout of 400ms because uiUtil.applyAnimationToSection uses a timeout of 300ms

diff --git a/www/js/lib/uiUtil.js b/www/js/lib/uiUtil.js
@@ -465,6 +465,7 @@ function isElementInView (el, fully) {
         return rect.top < window.innerHeight && rect.bottom > 0 && rect.left < window.innerWidth && rect.right > 0;
     }
 }
+
 /**
  * Show elements in bulk (using display: '')
  *
@@ -559,11 +560,11 @@ function fromSection () {
     const isConfigPageVisible = !$('#configuration').is(':hidden');
     const isAboutPageVisible = !$('#about').is(':hidden');
     const isArticlePageVisible = !$('#articleContent').is(':hidden');
-
     if (isConfigPageVisible) return 'config';
     else if (isAboutPageVisible) return 'about';
     else if (isArticlePageVisible) return 'home';
 }
+
 /**
  * Adds the slide animation between different sections
  *