-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement portable mode #1179
Implement portable mode #1179
Conversation
@sgourdas What is exactly the status here? It is mark ready to review, but still WIP and no reviewer? It's unclear. |
Changing to draft since getDataDirectory is not merged yet. I have finished work on the others. |
6a21a5c
to
99abf1f
Compare
Rebased with main and completed changes. Ready for review. |
WIP qualifier is no longer pertinent, I guess |
99abf1f
to
0e1dbed
Compare
0e1dbed
to
5906ebd
Compare
@sgourdas Sorry for the lack of feedback here, will look ASAP |
5906ebd
to
477658f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked finally your feature. This is on the good way, but it seems that the configuration is still take from the older "system" conf.
I see also no kiwix-desktop.conf
in the data
directory. Please verify that all configuration files from https://github.com/kiwix/kiwix-desktop/wiki/Data-and-Configuration-Files are read/write locally. Please update https://github.com/kiwix/kiwix-desktop/wiki/Data-and-Configuration-Files with a new "portable" column as well.
@sgourdas Any update? |
Sorry for the delay. I will update ASAP. |
420e1d0
to
862412a
Compare
@kelson42 what should the "portable" column have as information? |
The relative paths where the file are read/written |
I have set it up so in portable mode all files are written in the |
@veloman-yunkan I added support also for the download directory and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, this PR seems to perfctly implement #1166
@veloman-yunkan This is ready for the code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the current changes I have only a couple of insignificant proposals for improvement.
But regarding the portable functionality I have the following questions:
- Should we allow the user to change/set the download and monitored directories in portable mode?
- Should we allow adding ZIM files from outside the USB drive to the library in portable mode?
862412a
to
3edee85
Compare
I was thinking about this too and how strict we should be with the portable mode. IMO we should not be very restrictive and let the user choose. But, with the current implementation, if the download directory is changed and mode is portable, it would be set back to the |
How come it works like that? Isn't the download directory setting saved in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It does usually, but not in portable mode as per this PR. |
Why not? But to me this is something different: I have created #1203 I believe that per default, the
Why, not? At the end this is also a topic which is relevant for #1203 IMHO |
3edee85
to
78a50cf
Compare
This adds a check for the
.portable
file besides the executable. If it exists all application files will be saved in thedata
directory.Fixes #1166