Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPv6 in meson build of libmicrohttpd under Windows #761

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

veloman-yunkan
Copy link
Collaborator

Should fix kiwix/libkiwix#1144

Under Windows libmicrohttpd was being built with support for IPv6 disabled, which - according to debugging - was the main root cause of kiwix/libkiwix#1144. This PR should eliminate that problem.

@veloman-yunkan
Copy link
Collaborator Author

To test the effect of this PR with respect on kiwix-tools in a preexisting build tree

  1. Update the kiwix-build package in the virtual environment
  2. Remove libmicrohttpd directory from under both SOURCE and BUILD_native_static directories
  3. kiwix-build --config native_static libmicrohttpd and verify that BUILD_native_static/libmicrohttpd/MHD_config.h has MHD_HAVE_INET6 #defined as 1
  4. kiwix-build --config native_static kiwix-tools
  5. Test kiwix-serve

@veloman-yunkan
Copy link
Collaborator Author

The failure of the CI / Windows (native_static) job looks like a glitch in a non-deterministic unit-test. I will rerun the job when the CI completes.

@veloman-yunkan
Copy link
Collaborator Author

The failure of the CI / Windows (native_static) job looks like a glitch in a non-deterministic unit-test. I will rerun the job when the CI completes.

Done. CI is clean.

@kelson42
Copy link
Contributor

kelson42 commented Oct 8, 2024

@veloman-yunkan But we need to trigger the rebuild of the dependency I guess? Maybe an opportunity to upgrade to a more recent version (not sure about how to make a simple rebuild of the same version)?

Copy link
Collaborator

@sgourdas sgourdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my end as well. Nice.

@kelson42 kelson42 merged commit 642f63c into main Oct 8, 2024
42 checks passed
@kelson42 kelson42 deleted the libmicrohttpd_enable_ipv6_under_windows branch October 8, 2024 16:11
@veloman-yunkan
Copy link
Collaborator Author

@veloman-yunkan But we need to trigger the rebuild of the dependency I guess?

Good point. Let me see how it can be done.

Maybe an opportunity to upgrade to a more recent version (not sure about how to make a simple rebuild of the same version)?

Let's not seek for trouble without any compelling reason. I will find a way to update the dependency.

@kelson42
Copy link
Contributor

kelson42 commented Oct 8, 2024

@veloman-yunkan Maybe just updating https://github.com/kiwix/kiwix-build/blob/main/kiwixbuild/versions.py#L36 and tagging appropriatly to trigger the rebuild would be enough?

@veloman-yunkan
Copy link
Collaborator Author

veloman-yunkan commented Oct 8, 2024

@veloman-yunkan Maybe just updating https://github.com/kiwix/kiwix-build/blob/main/kiwixbuild/versions.py#L36 and tagging appropriatly to trigger the rebuild would be enough?

@kelson42 Thanks for the hint. Did it in #762. It seems that no tagging is needed. The CI of that PR will create the updated base_deps archives and after the PR is merged the new deps will be used by the nightlies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kiwix-serve cant instantiate HTTP daemon on windows
3 participants