-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable IPv6 in meson build of libmicrohttpd under Windows #761
Conversation
To test the effect of this PR with respect on
|
The failure of the CI / Windows (native_static) job looks like a glitch in a non-deterministic unit-test. I will rerun the job when the CI completes. |
Done. CI is clean. |
@veloman-yunkan But we need to trigger the rebuild of the dependency I guess? Maybe an opportunity to upgrade to a more recent version (not sure about how to make a simple rebuild of the same version)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my end as well. Nice.
Good point. Let me see how it can be done.
Let's not seek for trouble without any compelling reason. I will find a way to update the dependency. |
@veloman-yunkan Maybe just updating https://github.com/kiwix/kiwix-build/blob/main/kiwixbuild/versions.py#L36 and tagging appropriatly to trigger the rebuild would be enough? |
@kelson42 Thanks for the hint. Did it in #762. It seems that no tagging is needed. The CI of that PR will create the updated base_deps archives and after the PR is merged the new deps will be used by the nightlies. |
Should fix kiwix/libkiwix#1144
Under Windows
libmicrohttpd
was being built with support for IPv6 disabled, which - according to debugging - was the main root cause of kiwix/libkiwix#1144. This PR should eliminate that problem.