Merge pull request #779 from kiwix/windows_builds_in_release_mode

Under Windows builds are forced to release mode
kiwix · Nov 22, 2024 · 8c3ba3f · 8c3ba3f
2 parents 6cb347c + 1c69945
commit 8c3ba3f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/kiwixbuild/dependencies/base.py b/kiwixbuild/dependencies/base.py
@@ -538,6 +538,9 @@ class MesonBuilder(Builder):
 
     @property
     def build_type(self):
+        if platform.system() == "Windows":
+            return "release"
+
         return "release" if option("make_release") else "debug"
 
     @property

diff --git a/kiwixbuild/dependencies/kiwix_desktop.py b/kiwixbuild/dependencies/kiwix_desktop.py
@@ -20,14 +20,14 @@ class Builder(QMakeBuilder):
         @property
         def make_targets(self):
             if platform.system() == "Windows":
-                yield "release-all" if option("make_release") else "debug-all"
+                yield "release-all"
             else:
                 yield from super().make_targets
 
         @property
         def make_install_targets(self):
             if platform.system() == "Windows":
-                yield "release-install" if option("make_release") else "debug-install"
+                yield "release-install"
             else:
                 yield "install"
 

diff --git a/kiwixbuild/versions.py b/kiwixbuild/versions.py
@@ -33,7 +33,7 @@
 
 # This is the "version" of the whole base_deps_versions dict.
 # Change this when you change base_deps_versions.
-base_deps_meta_version = "09"
+base_deps_meta_version = "10"
 
 base_deps_versions = {
     "zlib": "1.2.12",