Avoid crash on iOS 18 #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPerlakiH
force-pushed
the
993-deleting-a-book-should-delete-related-tabs
branch
from
845654b
to
ec101e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
- Coverage 40.00% 39.12% -0.89%
==========================================
Files 114 114
Lines 6471 6472 +1
==========================================
- Hits 2589 2532 -57
- Misses 3882 3940 +58 ☔ View full report in Codecov by Sentry. |
|
Tested on iPadOS 18.0.1, and both delete and unlink work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #993
On iPad 18.1 the following webView function is deprecated, and leads to a crash:
Whereas deleting the book does work on 18.1 (simulator):
ipad_18.1_sim.mov
and it seems that unlinking the book also works on 18.1 (simulator):
ipad_18.1_sim_unlink.mov
Will test on device as well..