Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix categories parsing, when eTag 304 is used #1063

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #1007

As described in the re-opened issue, we need to handle the memory only stored categories to languages, when there's no new data coming from the http fetch (since it's 304, thanks to eTag).

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 36.87%. Comparing base (2a5195d) to head (cfdce82).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ViewModel/LibraryViewModel.swift 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   37.21%   36.87%   -0.34%     
==========================================
  Files         127      127              
  Lines        7519     7492      -27     
==========================================
- Hits         2798     2763      -35     
- Misses       4721     4729       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 force-pushed the categories-to-languages-fix-for-etag-304 branch from 9a52eaa to cfdce82 Compare January 3, 2025 12:41
@kelson42 kelson42 merged commit 4a0d565 into main Jan 3, 2025
7 checks passed
@kelson42 kelson42 deleted the categories-to-languages-fix-for-etag-304 branch January 3, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There seems to be no protection against fetching again an again the same version of the catalog
3 participants