Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the scanning of ZIM files in the Play Store variant. #4149

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Dec 30, 2024

Fixes #4148

  • Excluded the scanning of other directories in the Play Store variant, as only app-specific directories can be accessed, making it unnecessary to include other directories in the scan.
  • Fixed: UI was displaying storage options prematurely while storage information was still being fetched in the background. To resolve this, storage options are initially hidden, and a progress bar with a title is shown to inform users that storage information is being fetched.
    Issue:
    Screenshot_2024-12-29-20-05-31-21_924282dd390cc14aae1af1e29436bb16
    Fix:
screen-20241230-155042.mp4

* Excluded the scanning of other directories in the Play Store variant, as only app-specific directories can be accessed, making it unnecessary to include other directories in the scan.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as draft December 30, 2024 06:32
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 84.09091% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.82%. Comparing base (0969102) to head (d94fb5c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ixmobile/core/settings/StorageLoadingPreference.kt 83.33% 1 Missing and 10 partials ⚠️
...g/kiwix/kiwixmobile/settings/KiwixPrefsFragment.kt 83.33% 0 Missing and 2 partials ⚠️
...ile/nav/destination/library/CopyMoveFileHandler.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4149      +/-   ##
============================================
+ Coverage     56.79%   56.82%   +0.03%     
- Complexity     1515     1519       +4     
============================================
  Files           312      313       +1     
  Lines         13285    13367      +82     
  Branches       1644     1655      +11     
============================================
+ Hits           7545     7596      +51     
- Misses         4609     4637      +28     
- Partials       1131     1134       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…formation was still being fetched in the background.

* To resolve this, storage options are initially hidden, and a progress bar with a title is shown to inform users that storage information is being fetched.
@MohitMaliFtechiz MohitMaliFtechiz marked this pull request as ready for review December 30, 2024 10:48
@kelson42 kelson42 merged commit b04375b into main Dec 30, 2024
26 checks passed
@kelson42 kelson42 deleted the Fixes#4148 branch December 30, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data loss
3 participants