fix(KvLightbox): allow focus on open alerts, clicks on browser extensions and outside lightbox #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions and outside lightbox
mcstover
reviewed
Dec 6, 2023
| const { | ||
| activate: activateFocusTrap, | ||
| deactivate: deactivateFocusTrap, | ||
| } = useFocusTrap(kvLightbox); | ||
| } = useFocusTrap(trapElements, { | ||
| allowOutsideClick: true, // allow clicking outside the lightbox to close it |
There was a problem hiding this comment.
Does this need to be conditional based on props sent to the lightbox? We don't allow outside clicks in certain circumstances such as employee verification for campaign pages.
There was a problem hiding this comment.
This won't bypass our existing preventClose logic. If preventClose is true, clicking on the background won't close the lightbox. This just allows clicking on the background to close the lightbox when preventClose is false.
mcstover
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus trap was preventing closing tip message toasts and preventing clicking outside the lightbox to close it.
Using the
allowOutsideClick: trueoption allows clicking outside the focus trap, which then allows closing toasts and accessing elements added by browser extensions like password managers.Including the
'[role="alert"]'selector string in the focus trap array will include any open alerts in the focus trap, allowing for focusing on the alert close button using tab.