-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Each Platforms override HttpLoader's methods #861
Conversation
That is definitely a step in the right direction. I see another improvement probably not directly related to my request, but this change makes it easier. I would ask why Fuel class is using expect/actual? Some of the methods don't vary at all across platforms. The only platform specific thing in there is a line like this:
But you already have the platform specific mapping in FuelBuilder. It would seem to me that you could remove the expect/actual from the Fuel class and that line could just be:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comment about removing expect/actual from Fuel class (which can be handled separately), this was what I was looking for
Thinking about it shouldn't FuelBuilder just implement HttpLoaderFactory so you could just pass your your configured FuelBuilder to Fuel.setHttpLoader(factory)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also like this at well! Not a big fan of actual/expect class if we can avoid this.
Trying to avoid it with the old GC for Kotlin Native for new memory management. |
Thanks for the suggestions from #859. Did this meet your approval, @dalewking