-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More readme fixes #430
More readme fixes #430
Conversation
1d6b899
to
989b373
Compare
e80a884
to
fc6764c
Compare
Can we add some integration (or maybe even unit tests!?) for this functionality? |
f75fd64
to
f50b337
Compare
I added e2e tests for them and will move them to the processor later as part of #448. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor suggestions again. Please also correct the spelling mistakes in your commit messages.
I pushed some refactoring to this branch because I was working of off the review branch and I couldn't resist. Should have caught this in earlier reviews but |
6ef0704
to
026cf4d
Compare
Do you mean this line? Object.keys(kitspaceYaml.multi).forEach(async subProject => {
linkifiedKitspaceYaml.multi[subProject] = await renderProjectSummary(kitspaceYaml.multi[subProject])
}) |
Yeah, that creates an async function for each key in the yaml but doesn't await or return it. Just before that you had const linkifiedKitspaceYaml = kitspaceYaml Which references the same object and then you mutate it with the async functions. The scenario where this could have caused problems is if we had another sub-task that shares the Overall I'm wondering if this is really the right place to render the description. Shouldn't the frontend just handle it? It's fine for now... let's not spend time on it but something to think about for the future. |
|
d56c393
to
73b67b2
Compare
2540fb0
to
0bd5037
Compare
- The repo gets cloned before initializing the value for `default_branch` this can cause the jobs to get created without `default_branch`.
Co-authored-by: Kaspar Emanuel <[email protected]>
0bd5037
to
60d7549
Compare
ogx360
readme images are broken #421dropbot-40-channel-HV-switching-board
readme images #424GOSH-Board_UGM
readme images #426uduino
readme images #428