🌟feat: internal API proxy #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakayolo
approved these changes
Apr 12, 2021
|
|
||
| location /api { | ||
| rewrite /api/(.*) /$1 break; | ||
| proxy_pass http://kinto-core:8090; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solving this
We had the deployed dashboard connecting to the kinto-core API through the public network. (e.g. https://core.kinto.somedomain.com)
But for the case if we want to do port-forwarding, we have to forward both dashboard and the core
Here the idea is to do a reverse proxy inside the dashboard container, which forwards the connection to core through internal k8s connection (i.e. pod to pod connection via http://kinto-core:8090), and expose the proxy via
/api/*So if we do port-forwarding, we can expose only the dashboard and without any modifications to any env vars as we always connect to
/api