parser.go: ipv6 address without network mask support #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm I think for this we have to update go to at least 1.18. Fine with me |
|
I second it. go 1.18 was released more than two years ago. |
Before we would always add a `/32` to ip addresses without a `/`. This would be wrong for ipv6 addresses. They have 128 network masks. Signed-off-by: leonnicolas <[email protected]>
leonnicolas
force-pushed
the
ipv6-without-network-mask
branch
from
49d0675 to
b996c88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we would always add a
/32to ip addresses without a/. This would be wrong for ipv6 addresses. They have 128 network masks.