[DROOLS-5964] #1458
Draft
[DROOLS-5964] #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielezonca @yesamer |
|
Kudos, SonarCloud Quality Gate passed! |
jomarko
reviewed
Feb 2, 2021
| @@ -78,7 +78,7 @@ public void validateValidDMN() { | |||
| public void addRadioButtons() { | |||
| reset(uploadWidgetMock); | |||
| sourceTypeSelector.addRadioButtons(); | |||
| assertEquals(2, sourceTypeSelector.radioButtonList.size()); | |||
| assertEquals(3, sourceTypeSelector.radioButtonList.size()); | |||
There was a problem hiding this comment.
@gitgabrio according this change, do I understand correctly from now on TestScenario asset will serve for testing of:
- DRL rules- old
- DMN models - old
- PMML models - new
?
There was a problem hiding this comment.
@jomarko
yes, that's the plan. The backend is ready, unfortunately frontend would need other modifications that no-one can do right now, so both PRs are on "stand-by"
# Conflicts: # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-kogito-client/src/main/java/org/drools/workbench/screens/scenariosimulation/kogito/client/converters/ApiJSInteropConverter.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-kogito-client/src/main/java/org/drools/workbench/screens/scenariosimulation/kogito/client/converters/JSInteropApiConverter.java # drools-wb-screens/drools-wb-scenario-simulation-editor/drools-wb-scenario-simulation-editor-kogito-marshaller/src/main/resources/scesim.xsd
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielezonca @yesamer @jomarko
see https://issues.redhat.com/browse/DROOLS-5964
Minimal required modifications to xsd/converters/tests.
Depends on https://github.com/kiegroup/drools/pull/3344