Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiples exploits with pmms:start event #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ekinoxx0
Copy link

@Ekinoxx0 Ekinoxx0 commented Oct 9, 2022

This PR move some checks before addToQueue function

Before, this would allow adding to queue links that are not authorized or without permission (even if checked on client, it's better to have this check properly on server-side)

This also block an exploit that would allow playing "file://" url, causing an instant crash to all client close to the player.
(See this ResourceUIScripting.cpp#L39)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant