Revoked identity listed as valid #85
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really a PR but we have have an issue on go-gitea/gitea#6778 with a revoked identity being listed as valid.
The goal is to find the reason and fix this in the PR.
So, I added a test with the user public key to confirm the bug. (If we found the exact reason I will generate a dummy one and rebase)
I haven't found the culprit so if you can have a look.
For the details,
What version of Go are you using (go version)? 1.13
What operating system and processor architecture are you using? linux
What did you do? use a key with revoked id and a valid one
What did you expect to see? only the valid one
What did you see instead? both ids
sidenote: I don't think it is bound to os/platform/go version.
Thanks in advance for any help you can provide.