Bring in the latest from golang/crypto upstream #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good idea, we should do this, we're just swamped right now with other stuff. will hopefully get to it soon. |
|
I can have a try with this once #40 is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 hello again!
I'm not sure if this is the way you normally do this, or if commits are cherry-picked more intentionally. So I thought I'd propose this and start the discussion on the best way to move forward.
We'd like to continue using the keybase fork of the
golang/cryptorepo for the other additions that have been added, but I also wanted to get things synced up so further work could be added based on top of it - specifically now that a ed25519 implementation exists upstream. I'd like to try and get support for that added to theopenpgppackage.What do you think would be the best way forward?
FYI there were a handful of merge conflicts but I unfortunately didn't keep track of which files they were :\