Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage 4cal (Calibrated Stellar Spectra) #728

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Stage 4cal (Calibrated Stellar Spectra) #728

wants to merge 23 commits into from

Conversation

kevin218
Copy link
Owner

@kevin218 kevin218 commented Dec 16, 2024

This PR adds a new step to the Eureka! pipeline. Stage 4cal produces calibrated stellar spectra over two regions (typically in and out of transit/eclipse) with uncertainties. In addition, I've added the following:

  1. A new folder to Demos that steps through Stages 2, 3, and 4cal using NIRSpec G395H as an example
  2. A suitable description of the new ECF parameters for the website
  3. New tests that include a NIRSpec file from actual data, thus replacing the simulated FITS file.

Copy link
Collaborator

@taylorbell57 taylorbell57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't made it through all the files yet (and haven't looked at most of your new code yet), but here are some preliminary comments

docs/source/stages.rst Show resolved Hide resolved
tests/test_NIRSpec.py Outdated Show resolved Hide resolved
tests/test_NIRSpec.py Show resolved Hide resolved
@sebastian-zieba
Copy link
Collaborator

Hi, I'm currently testing this PR on some MIRI/LRS data and it works great!
Just wanted to say that I guess the run_eureka.py file should be updated too with something like
meta, spec, ds = s4cal.medianCalSpec(eventlabel, ecf_path=ecf_path)

@kevin218
Copy link
Owner Author

Hi, I'm currently testing this PR on some MIRI/LRS data and it works great! Just wanted to say that I guess the run_eureka.py file should be updated too with something like meta, spec, ds = s4cal.medianCalSpec(eventlabel, ecf_path=ecf_path)

I'm glad it's working out and thanks for the suggestion! I've added a suitable run_eureka.py file to the S4cal demos folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants