Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type annotations for buy and sell methods #975

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add return type annotations for buy and sell methods #975

wants to merge 2 commits into from

Commits on May 2, 2023

  1. ENH: Explicitly import annotations everywhere 

    Type annotations are now explicitly imported
from `__future__` to allow forward references
and postponed evaluation (faster import time).
See PEP 563 for details.
    @ivaigult
    ivaigult committed May 2, 2023
    Configuration menu
    Copy the full SHA
    56bc68f View commit details
    Browse the repository at this point in the history

  2. ENH: add return type annotations for buy/sell 

    The return type annotations are now added for `buy`
and `sell` methods. The documentation is updated to
mention that the `Order` is returned. Now it should
be crystal clear how to cancel a non-executed order.

This should address kernc#957.
    @ivaigult
    ivaigult committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b5c9cdb View commit details
    Browse the repository at this point in the history