Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing pct instead of ATR #223 #377

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
37 changes: 37 additions & 0 deletions backtesting/lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,43 @@ def next(self):
self.data.Close[index] + self.__atr[index] * self.__n_atr)


class PercentageTrailingStrategy(Strategy):
"""
A strategy with automatic trailing stop-loss, trailing the current
price at distance of some percentage. Call
`PercentageTrailingStrategy.set_trailing_sl()` to set said percentage
(`5` by default). See [tutorials] for usage examples.

[tutorials]: index.html#tutorials

Remember to call `super().init()` and `super().next()` in your
overridden methods.
"""
_sl_pct = 5.

def init(self):
super().init()

def set_trailing_sl(self, percentage: float = 5):
assert percentage > 0, "percentage must be greater than 0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everywhere else, the framework uses "pct" and "percent" to really mean rate (e.g. 5% == 0.05). I wonder if here shouldn't be the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are you saying that a user should be inputting 0.05 instead of 5 and the code should use that value as is?

"""
Sets the future trailing stop-loss as some (`percentage`)
percentage away from the current price.
"""
self._sl_pct = percentage/100

def next(self):
super().next()
index = len(self.data)-1
for trade in self.trades:
if trade.is_long:
trade.sl = max(trade.sl or -np.inf,
self.data.Close[index]*(1-self._sl_pct))
else:
trade.sl = min(trade.sl or np.inf,
self.data.Close[index]*(1+self._sl_pct))
Comment on lines +482 to +489
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
index = len(self.data)-1
for trade in self.trades:
if trade.is_long:
trade.sl = max(trade.sl or -np.inf,
self.data.Close[index]*(1-self._sl_pct))
else:
trade.sl = min(trade.sl or np.inf,
self.data.Close[index]*(1+self._sl_pct))
price = self.data.Close[-1]
for trade in self.trades:
if trade.is_long:
trade.sl = max(trade.sl or -np.inf, price*(1 - self._sl_pct))
else:
trade.sl = min(trade.sl or np.inf, price*(1 + self._sl_pct))

Copy link
Contributor Author

@zlpatel zlpatel Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I make this change, I want to let you know that I used index = len(self.data)-1 instead of -1 to be consistent with the TrailingStrategy code. I understand that in TrailingStrategy, we were using ATR which was computed differently and to get an absolute value for an index, we had to use len(self.data)-1, But I don't see any harm in using it here. Thoughts?



# Prevent pdoc3 documenting __init__ signature of Strategy subclasses
for cls in list(globals().values()):
if isinstance(cls, type) and issubclass(cls, Strategy):
Expand Down
16 changes: 16 additions & 0 deletions backtesting/test/_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
quantile,
SignalStrategy,
TrailingStrategy,
PercentageTrailingStrategy,
resample_apply,
plot_heatmaps,
random_ohlc_data,
Expand Down Expand Up @@ -862,6 +863,21 @@ def next(self):
stats = Backtest(GOOG, S).run()
self.assertEqual(stats['# Trades'], 57)

def test_PercentageTrailingStrategy(self):
class S(PercentageTrailingStrategy):
def init(self):
super().init()
self.set_trailing_sl(5)
self.sma = self.I(lambda: self.data.Close.s.rolling(10).mean())

def next(self):
super().next()
if not self.position and self.data.Close > self.sma:
self.buy()

stats = Backtest(GOOG, S).run()
self.assertEqual(stats['# Trades'], 91)


class TestUtil(TestCase):
def test_as_str(self):
Expand Down