Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Efficientnet Edge presets #1976

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Add Efficientnet Edge presets #1976

merged 10 commits into from
Nov 13, 2024

Conversation

pkgoogle
Copy link
Collaborator

@pkgoogle pkgoogle commented Nov 7, 2024 •
edited
Loading

Adds these presets:

efficientnet_el_ra_imagenet
efficientnet_em_ra2_imagenet
efficientnet_es_ra_imagenet

Tested Colab

@pkgoogle pkgoogle changed the title Add edge presets Add Efficientnet Edge presets Nov 7, 2024
@pkgoogle pkgoogle mentioned this pull request Nov 11, 2024
Open
@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Nov 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Nov 12, 2024
divyashreepathihalli
divyashreepathihalli requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pkgoogle. I left a few comments, can you also please add a demo colab notebook to show it is working?

keras_hub/src/models/efficientnet/efficientnet_backbone.py Show resolved Hide resolved
keras_hub/src/models/efficientnet/efficientnet_presets.py Outdated
"path": "efficientnet",
"model_card": "https://arxiv.org/abs/1905.11946",
},
"kaggle_handle": "kaggle://keras/efficientnet/keras/efficientnet_b1_ft_imagenet",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add version number of the model in the kaggle handle.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

keras_hub/src/models/efficientnet/fusedmbconv.py Show resolved Hide resolved
keras_hub/src/models/efficientnet/mbconv.py Show resolved Hide resolved
@pkgoogle pkgoogle added the kokoro:force-run Runs Tests on GPU label Nov 12, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Nov 12, 2024
@pkgoogle
Copy link
Collaborator Author

The remaining test appears irrelevant

@divyashreepathihalli divyashreepathihalli merged commit 4a287cd into keras-team:master Nov 13, 2024
9 of 10 checks passed
@pkgoogle pkgoogle deleted the add_edge_presets branch November 13, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyashreepathihalli divyashreepathihalli divyashreepathihalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkgoogle @divyashreepathihalli @kokoro-team