This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
Swish activation saves beta as weight even if it is not trainable #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm a bot! I can make mistakes, notify gabrieldemarmiesse if I made one. I see that you modified the following file:
The owner of those file is @gabrieldemarmiesse @gabrieldemarmiesse could you please take a look at it whenever |
|
Closing because of the discussion in #482. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Allows to save beta as weights when a model is saved even if beta is not trainable.
- How I did it
Adding "trainable" argument to the weight.
- How you can verify it
This pull request fixes #482