Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Black, isort and flake8 with Ruff check and formatter #1931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Nov 6, 2024

This PR replaces Black, isort and flake8 with Ruff.

Changes to the source files are due to ruff format; there were no changes required for ruff check.

Other changes in this PR:

  • Python version in docker/pre-commit.Dockerfile is upgraded to minimum version
  • Options for pytest and cov are migrated from setup.cfg to pyproject.toml
  • Shebangs and bash options in shell scripts are added, similar to the main keras repo

See also these recent changes to keras:

Copy link
Collaborator

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
We would prefer to keep the linter and formatter unchanged for the moment to avoid any unexpected new workload added by it later.
The current linter and formatter work fine for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants