fix: zsh script #65
Merged
fix: zsh script #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ayush Sharma <[email protected]>
Signed-off-by: Ayush Sharma <[email protected]>
Signed-off-by: Ayush Sharma <[email protected]>
khareyash05
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
LGTM! Not able to replicate on Bash shell but works on @ayush3160 when he sets his default terminal to bash
Also have to check that in test sudo is 2 times required
Signed-off-by: Ayush Sharma <[email protected]>
khareyash05
approved these changes
Sep 26, 2024
shivamsouravjha
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: zshScript Signed-off-by: Ayush Sharma <[email protected]> * removed comments Signed-off-by: Ayush Sharma <[email protected]> * fixed scripts Signed-off-by: Ayush Sharma <[email protected]> * removed sudo Signed-off-by: Ayush Sharma <[email protected]> --------- Signed-off-by: Ayush Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed zsh script and changed the one click install command.
fixes #2309