Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed internal params from the default config string #14

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

ayush3160
Copy link
Contributor

fixes : #2168

Description

In this PR I have removed some internal params from the default config file string which is used to intialise the config.

Signed-off-by: ayush3160 <[email protected]>
@Sonichigo
Copy link
Member

@ayush3160 can you resolve the conflicts

@ayush3160
Copy link
Contributor Author

@Sonichigo , Is there any reason to commit out folder ? , I mean it is a build folder right.

@Sonichigo
Copy link
Member

@ayush3160 no need to commit you can just resolve the conflicts via CLI. Since with the new release of the vscode extension version the old .out was deprecated. You can also resolve the conflict via web editior

@ayush3160
Copy link
Contributor Author

@Sonichigo , I have resolved the conflicts please have a look.

@Sonichigo Sonichigo self-requested a review August 21, 2024 02:03
Copy link
Member

@Sonichigo Sonichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sonichigo Sonichigo merged commit bfe556b into keploy:main Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Remove internal config params while generating config in vscode extension
2 participants