Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Tailwind and custom themes for Dark and Light #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sanjay-xdr
Copy link

@sanjay-xdr sanjay-xdr commented Jul 30, 2024

Fixes #2145
Fixes #2143

  • Installed Tailwind CSS and configured it within the project

  • Replaced existing CSS classes with Tailwind CSS utility classes.

  • Added Custom Theme

  • Screenshot after using tailwind css
    imp-1

imp-2

imp-3

Extension.Development.Host.keploy.yml.-.Visual.Studio.Code.2024-08-07.10-04-00.mp4

@Sonichigo
Copy link
Member

@Akash-Singh04 can you review the pr!

Copy link
Contributor

@SkySingh04 SkySingh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, could you send in a screenrecording of the UI after the tailwind changes so that we make sure the UI hasn't changed?

@SkySingh04
Copy link
Contributor

Also @sanjay-xdr If you are working on #2143 as well, kindly push those changes to the same PR and update the title and desc!

@sanjay-xdr
Copy link
Author

Is there a place where I can ask questions or discuss queries?

@SkySingh04
Copy link
Contributor

@sanjay-xdr Feel free to post them here so that either of the maintainers can help you out as soon as possible!

Signed-off-by: Sanjay Jaiswal <[email protected]>
Signed-off-by: Sanjay Jaiswal <[email protected]>
Signed-off-by: Sanjay Jaiswal <[email protected]>
@sanjay-xdr sanjay-xdr changed the title Adding tailwind Added Support for Tailwind and custom themes for Dark and Light Aug 7, 2024
@sanjay-xdr
Copy link
Author

Please review this pr

@SkySingh04
Copy link
Contributor

@Sonichigo Can you review the video and see if the themes align with the expectations?

@SkySingh04
Copy link
Contributor

@sanjay-xdr Can you resolve the conflicts please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants