Adding Unit test cases for wrappedNodeFetch and adding github actions #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @re-Tick! Can you please review the PR? |
|
@Hermione2408 please resolve DCO and commitzen |
Hermione2408
force-pushed
the
test#354
branch
3 times, most recently
from
5cebecf
to
7270469
Compare
|
Can you have a look now @re-Tick |
re-Tick
reviewed
Mar 9, 2023
re-Tick
added
Don't Merge
re-Tick
reviewed
Mar 10, 2023
|
Hey @re-Tick , Can you please review the changes now |
|
a test is failing. I will try these changes locally and request changes if any. |
|
Sure I'll try to resolve too where they are failing |
re-Tick
reviewed
Mar 14, 2023
test/wrappedNodeFetch.test.ts
Outdated
|
|
||
| describe('wrappedNodeFetch', () => { | ||
| it('should call fetch function with correct arguments in record mode', async () => { | ||
| const mockFetch = jest.fn().mockResolvedValueOnce(new Response()); |
There was a problem hiding this comment.
Since, outputs are recorded when end event is triggered for response of fetch. We dont need to mock fetch here. We can use the actual fetch of node-fetch
re-Tick
reviewed
Mar 14, 2023
test/wrappedNodeFetch.test.ts
Outdated
| deps: [], | ||
| }; | ||
| createExecutionContext(ctx) | ||
| const wrappedFetch = (wrappedNodeFetch(mockFetch) as any).bind({ fetch: mockFetch }); |
There was a problem hiding this comment.
And pass actual fetch here. To capture the outputs.
re-Tick
reviewed
Mar 14, 2023
test/wrappedNodeFetch.test.ts
Outdated
| }; | ||
| createExecutionContext(ctx) | ||
| const wrappedFetch = (wrappedNodeFetch(mockFetch) as any).bind({ fetch: mockFetch }); | ||
| const url = 'http://example.com'; |
There was a problem hiding this comment.
We can use keploy's health API "https://api.keploy.io/healthz" here as url
re-Tick
reviewed
Mar 14, 2023
test/wrappedNodeFetch.test.ts
Outdated
| const deps=updatedctx.deps.length; | ||
| const responseBody = await response.text(); | ||
| const recordedOutput = updatedctx.mocks[0].Spec.Res.Body; | ||
| expect(mockFetch).toHaveBeenCalledWith(url, options); |
There was a problem hiding this comment.
We also dont need to do this since we use actual fetch of node-fetch
|
@re-Tick I have made the changes and it is passing all the test cases now. |
…b action and wrote unit test For code coverage added unit test for wrappedNodeFetch function and integrated git hub actions. test #354 Signed-off-by: Hermione Dadheech <[email protected]>
Signed-off-by: Hermione Dadheech <[email protected]>
Revert version and removing console from unit test file test #354 Signed-off-by: Hermione Dadheech <[email protected]>
Added expect test for mocks and deps after fetching in record and test mode test #354 Signed-off-by: Hermione Dadheech <[email protected]>
… output with response Added a check to compare the recorded output with response to ensure wrappedNodeFetch functionality test #354 Signed-off-by: Hermione Dadheech <[email protected]>
importing HTTP from src/keploy.ts test #354 Signed-off-by: Hermione Dadheech <[email protected]>
…reateExecutionContext Resolving the failed test cases by using fetch from node-fetch and createExecutionContext test#354 Signed-off-by: Hermione Dadheech <[email protected]>
updating test cases test #354 Signed-off-by: Hermione Dadheech <[email protected]>
removing createExecutionContext from octokit test #354 Signed-off-by: Hermione Dadheech <[email protected]>
|
LGTM. Please add this PR link in GSOC task list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code coverage added unit test for wrappedNodeFetch function and integrated git hub actions.
test #354
Closes: keploy/keploy#354