gh-44 remove/replace headers while recording tc #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @shreyanshshah27, please make changes for mock library to remove and replace fields |
Signed-off-by: Shreyansh Shah <[email protected]>
shreyanshshah27
force-pushed
the
feature/gh-44
branch
from
b939e50
to
f71f27a
Compare
Signed-off-by: Shreyansh Shah <[email protected]>
|
Hey @re-Tick Please review the PR, I've made the required changes in mock library to support this feature. |
re-Tick
reviewed
Mar 3, 2023
mock/mock.ts
Outdated
| @@ -71,6 +73,8 @@ export function NewContext(conf: Config) { | |||
| testId: conf.Name, | |||
| mocks: [], | |||
| fileExport: true, | |||
| Remove: conf.Remove, | |||
There was a problem hiding this comment.
This Remove and Replace should be added in record mode. Since we filtering during recording.
There was a problem hiding this comment.
You are correct. I've fixed this.
Signed-off-by: Shreyansh Shah <[email protected]>
re-Tick
added
gsoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes keploy/keploy#395