fix : do not record test-case while in test mode #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyanshshah27
force-pushed
the
bugfix/gh-42
branch
from
e175d67
to
8903359
Compare
|
Hi @shreyanshshah27, CI is failing due to incorrect commit format. Please follow this format "fix: <COMMIT_MESSAGE>" |
Signed-off-by: Shreyansh Shah <[email protected]>
shreyanshshah27
force-pushed
the
bugfix/gh-42
branch
from
8903359
to
a170453
Compare
|
Hey @re-Tick I've made the commit name changes. |
re-Tick
reviewed
Mar 2, 2023
integrations/express/middleware.ts
Outdated
| @@ -139,6 +139,9 @@ export function afterMiddleware(keploy: Keploy, req: Request, res: Response) { | |||
| return; | |||
| } | |||
|
|
|||
| if (process.env.KEPLOY_MODE=="test") { | |||
There was a problem hiding this comment.
Please use MODE_TEST constant intead of "test" here and use "equality without type coersion”.
Signed-off-by: Shreyansh Shah <[email protected]>
|
Hey @shreyanshshah27, Please add link to this PR in GSOC/2023 Task List. |
re-Tick
added
good first issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.