add: json diff viewer #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
slayerjain
reviewed
Aug 6, 2024
jsondiff.go
Outdated
| // ColorizedResponse holds the colorized differences between the expected and actual JSON responses. | ||
| // ExpectedResponse: The colorized string representing the differences in the expected JSON response. | ||
| // ActualResponse: The colorized string representing the differences in the actual JSON response. | ||
| type ColorisedResponse struct { |
slayerjain
reviewed
Aug 6, 2024
jsondiff.go
Outdated
| // ExpectedResponse: The colorized string representing the differences in the expected JSON response. | ||
| // ActualResponse: The colorized string representing the differences in the actual JSON response. | ||
| type ColorisedResponse struct { | ||
| ExpectedResponse string |
There was a problem hiding this comment.
these could be expected and actual?
slayerjain
reviewed
Aug 6, 2024
jsondiff.go
Outdated
| // json2: The second JSON object to compare. | ||
| // noise: A map containing fields to ignore during the comparison. | ||
| // Returns a ColorizedResponse containing the colorized differences for the expected and actual JSON responses. | ||
| func ColorJSONDiff(json1 []byte, json2 []byte, noise map[string][]string) (ColorisedResponse, error) { |
slayerjain
reviewed
Aug 6, 2024
jsondiff.go
Outdated
| // expect: The JSON string containing the expected values. | ||
| // actual: The JSON string containing the actual values. | ||
| // Returns a ColorizedResponse containing the colorized differences for the expected and actual JSON responses. | ||
| func ColorDiff(expect, actual string) ColorisedResponse { |
slayerjain
reviewed
Aug 6, 2024
jsondiff.go
Outdated
| // expect: The map containing the expected header values. | ||
| // actual: The map containing the actual header values. | ||
| // Returns a ColorizedResponse containing the colorized differences for the expected and actual headers. | ||
| func ColorHeaderDiff(expect, actual map[string]string) ColorisedResponse { |
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
gouravkrosx
reviewed
Sep 24, 2024
jsondiff.go
Outdated
| End int // End is the ending index of the range. | ||
| } | ||
|
|
||
| // ColorizedResponse holds the colorized differences between the expected and actual JSON responses. |
There was a problem hiding this comment.
Change the comment, since there is not struct named as ColorizedReponse
gouravkrosx
reviewed
Sep 24, 2024
| } | ||
|
|
||
| // isControlCharacter checks if a character is a control character. | ||
| func isControlCharacter(char rune) bool { |
There was a problem hiding this comment.
Please explain it more. This doesn't explain what a control character is.
gouravkrosx
reviewed
Sep 24, 2024
jsondiff.go
Outdated
| } | ||
|
|
||
| // maxLineLength is the maximum length of a line before it is wrapped. | ||
| const max_line_length = 50 |
|
@shivamsouravjha Add a pipeline to trigger the unit tests. |
Signed-off-by: shivamsouravjha <[email protected]>
Signed-off-by: shivamsouravjha <[email protected]>
gouravkrosx
reviewed
Sep 25, 2024
| if !reflect.DeepEqual(val1, val2) { | ||
| // Marshal values to pretty-printed JSON strings | ||
| val1Str, err := json.MarshalIndent(val1, "", " ") | ||
| if err != nil { |
There was a problem hiding this comment.
why are you not printing the error?
There was a problem hiding this comment.
considering this to be a sdk I thought of not adding print statements.
gouravkrosx
reviewed
Sep 25, 2024
| } | ||
| val2Str, err := json.MarshalIndent(val2, "", " ") | ||
| if err != nil { | ||
| return |
gouravkrosx
reviewed
Sep 25, 2024
| nextLine := lines[i+1] | ||
|
|
||
| // Process lines that start with a '-' indicating expected differences. | ||
| if len(line) > 0 && line[0] == '-' && i != len(lines)-1 { |
There was a problem hiding this comment.
Do you think that the condition len(line)>0 can happen anytime?
There was a problem hiding this comment.
yes ,I've explicitly appended empty string in the lines in
lines = insertEmptyLines(lines) // Insert empty lines between consecutive elements with the same symbol.
So that two ++ signs don't come after each other
gouravkrosx
requested changes
Sep 25, 2024
Signed-off-by: shivamsouravjha <[email protected]>
gouravkrosx
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.