New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keploy fails to stop when tests end #156

Merged

gouravkrosx merged 1 commit into main from kill-keploy-process

Sep 28, 2023

Member

gouravkrosx commented Sep 28, 2023

Related Issue

Keploy fails to stop when tests end. This happens in the case of Junit integration with keploy.

Closes: keploy/keploy#864

Describe the changes you've made

Added a function to not just kill the parent but child processes sharing the same running port.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas and used java doc.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original	Updated
original screenshot	updated screenshot


          fix: keploy fails to stop when tests end

dbf6802

Signed-off-by: gouravkrosx <[email protected]>

github-actions bot reviewed

View reviewed changes

v2/src/main/java/io.keploy.cli/KeployCLI.java

                       try {
-                          Process process = Runtime.getRuntime().exec(command);
+                          Process process = new ProcessBuilder("sh", "-c", "lsof -t -i:" + port).start();

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 80 characters (found 91).

v2/src/main/java/io.keploy.cli/KeployCLI.java

                           }
                       } catch (Exception e) {
                           e.printStackTrace();
+                          System.err.println("Failed to fetch the process ID on port " + port);

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 80 characters (found 81).

v2/src/main/java/io.keploy.cli/KeployCLI.java

+                      }
+                  }
+                  public static void killProcessesAndTheirChildren(int parentPID) {

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

v2/src/main/java/io.keploy.cli/KeployCLI.java

+                      }
+                  }
+                  public static void killProcessesAndTheirChildren(int parentPID) {

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter parentPID should be final.

v2/src/main/java/io.keploy.cli/KeployCLI.java

+                      for (int childPID : pids) {
+                          if (childPID != getCurrentPid()) {
+                              try {
+                                  new ProcessBuilder("sudo", "kill", "-9", String.valueOf(childPID)).start();

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 80 characters (found 95).

v2/src/main/java/io.keploy.cli/KeployCLI.java

    
                      }

                  }

                  private static void forceKillProcessByPID(String pid) {

                  public static void findAndCollectChildProcesses(String parentPID, List<Integer> pids) {

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

v2/src/main/java/io.keploy.cli/KeployCLI.java

    
                      }

                  }

                  private static void forceKillProcessByPID(String pid) {

                  public static void findAndCollectChildProcesses(String parentPID, List<Integer> pids) {

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter parentPID should be final.

v2/src/main/java/io.keploy.cli/KeployCLI.java

    
                      }

                  }

                  private static void forceKillProcessByPID(String pid) {

                  public static void findAndCollectChildProcesses(String parentPID, List<Integer> pids) {

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter pids should be final.

v2/src/main/java/io.keploy.cli/KeployCLI.java

-                          logger.debug("cmd to kill:{}",cmd);
-                          Runtime.getRuntime().exec("kill -9 " + pid);
+                          pids.add(Integer.parseInt(parentPID));
+                          Process process = new ProcessBuilder("pgrep", "-P", parentPID).start();

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 80 characters (found 83).

v2/src/main/java/io.keploy.cli/KeployCLI.java

-                          Runtime.getRuntime().exec("kill -9 " + pid);
+                          pids.add(Integer.parseInt(parentPID));
+                          Process process = new ProcessBuilder("pgrep", "-P", parentPID).start();
+                          BufferedReader reader = new BufferedReader(new InputStreamReader(process.getInputStream()));

github-actions bot Sep 28, 2023

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 80 characters (found 104).

gouravkrosx merged commit 48d2cfe into main

2 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet