pic: Improve rendered image quality #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by reducing the line thickness of each pixel to minimize overlap
kennytm
approved these changes
Jul 10, 2024
|
i'll wait for a few days before publishing a release in case you've got some more changes 😄 |
|
Thanks for merging this so quickly, @kennytm, very much appreciated 🙏 and apologies for not having caught this while working on the initial PR and now causing extra work. Leaving new changes out to dry, so to speak, before a new release seems like a good idea 🙂👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by reducing the line thickness of each pixel to minimize overlap.
Hi @kennytm, 👋🙂
while working on adding support for PIC output format to
sorairolake/qrtoolI noticed that in certain configuration the pixel may overlap, resulting in a somewhat "smudged" look of the QR code.The codes functionality is not affected by this, yet I think having the code appear "crispy" is desirable. Judging from the examples below, what are your thoughts on this?