feat: support partially extending bases & adjustable half-grid hole positions #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this might go against the basic principle of gridfinity, I had a drawer that did not have an inner size that was a nice multiple of 42. But I still want to make use of the extra 2cm, so I added support to extend the grid with partial bases as I'd rather have some bins that I can only use on one side of the drawers then leave a gap of 2cm.
This PR also adds support to configure how the magnet holes should be positioned when using half grids.
Extend bases with 2cm to the left and 7mm to the back. Note that there aren't bottom notches added on the extra 7mm yaxis because the bottom notches have a minimum dimension of
2*BASE_TOP_RADIUS. See the warning that is being echoedCompartments are still equally divided taking the extra dimensions into account:
Default / current behaviour for placement of half grid holes:
Alternate y alignment like the full width base pattern but keep all holes left aligned:
Use the default hole pattern for full width bases:
