Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #252 #253

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix #252 #253

merged 1 commit into from
Nov 27, 2024

Conversation

madhephaestus
Copy link
Contributor

@madhephaestus madhephaestus commented Nov 25, 2024

close #252
close #246

@madhephaestus
Copy link
Contributor Author

@EmperorArthur this line was commented out about a month ago and was committed. it seems to have caused issues with exporting working base plates. Can you please merge this fix?

madhephaestus referenced this pull request Nov 25, 2024
* Simplified.
* More readable.
* Prevents gaps that could be left by old logic. (rounded_square)
@EmperorArthur EmperorArthur self-requested a review November 27, 2024 17:04
Copy link
Collaborator

@EmperorArthur EmperorArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix!

Just shows even more automation and testing is needed.

@EmperorArthur EmperorArthur merged commit e1e5dcc into kennetek:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thin Style Baseplates Not Rendering Properly Error on render after commit a13f526
2 participants